-
-
Notifications
You must be signed in to change notification settings - Fork 431
Fix dialogs UI scalability #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time and making the screencasts about the expected behavior. Very nice 👍
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
747a9a9
to
87316e8
Compare
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Show resolved
Hide resolved
dad0c76
to
26cbba6
Compare
I've put the PR back in draft because I've decreased the IDE version for testing purposes: 26cbba6 UPDATE: |
26cbba6
to
27561f4
Compare
3bf97b5
to
bfecd88
Compare
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-component.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx
Outdated
Show resolved
Hide resolved
a4e7229
to
87f54f2
Compare
arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements Alberto!
Motivation
As explained in #1309, our dialogs might become distorted when scaling up the UI (from the settings or using the shortcut CMD/CTRL + '+').
I've made some fixes in order to make the interface readable and usable with an interface that is scaled up to 200%, with a minimum window size of 450px in width and 300px in height. Maybe they won't look beautiful, but every dialog should be at least usable and readable up to that size.
Change description
Here's a list of screen captures before the changes, with an interface scale of 200% and a window size of 450x300:
Settings dialog
IDE auto-update dialog
Screen.Recording.2022-08-09.at.09.39.43.mov
Select Board dialog
Screen.Recording.2022-08-09.at.09.42.53.mov
WiFi 101/WiFi NINA Firmware Updater dialog
Upload SSL Root Certificates
And after the changes:
Settings dialog
Screen.Recording.2022-08-09.at.09.29.03.mov
To avoid the '%' symbol unexpectedly going to a new line, I've added a
unitOfMeasure
prop to the settings-step-input component: a9ed5b5IDE auto-update dialog
Screen.Recording.2022-08-09.at.09.37.09.mov
I needed to apply a major refactor on this dialog in order to move the buttons from the content of the dialog (which is the inner react component) to the footer (which is part of the
AbstractDialog
inherited from Theia): 553c6feSelect Board dialog
Screen.Recording.2022-08-09.at.09.42.38.mov
Here I've decided to save some space when the size of the window is very small by adding a media query that removes the upper text paragraph on screen heights smaller than 400px: f8f07ea62be6d96191759c89da26c7fb5327c0fff8f07ea62be6d96191759c89da26c7fb5327c0ff
WiFi 101/WiFi NINA Firmware Updater dialog
Upload SSL Root Certificates
Screen.Recording.2022-08-09.at.09.47.55.mov
Other information
Fixes #1309
Reviewer checklist